Sync switch execution mode display#17
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6915fb7a7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| normalized[platform][String(key)] = { | ||
| strategy_profile: profile, | ||
| execution_mode: normalizeExecutionMode(entry?.execution_mode, entry?.dry_run_only), | ||
| dry_run_only: entry?.dry_run_only === true || entry?.dry_run_only === "true" || entry?.dry_run_only === "1", |
There was a problem hiding this comment.
When /api/config returns a current strategy entry that has no execution_mode and no dry_run_only (for example a legacy STRATEGY_PROFILE fallback for an explicitly paper account), this normalization stores dry_run_only: false. defaultExecutionModeForAccount() then treats that synthetic false as an explicit live mode and returns before checking the account's paper hint, so those paper accounts render and dispatch as Live instead of Dry run. Preserve the unknown state here instead of converting every missing value to false.
Useful? React with 👍 / 👎.
1 participant
Summary
Tests